Skip to content

Fix DRA conformance config #5756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

Fix DRA conformance config #5756

merged 1 commit into from
Jul 15, 2025

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jul 15, 2025 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:

The label filter we use to select DRA e2e tests to run in the conformance job seems to have gotten out of sync with upstream such that now no tests are run at all. This change updates the label filter to match the k/k pull-kubernetes-kind-dra job which exercises the functionality that requires only the DynamicResourceAllocation feature gate.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 15, 2025

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra

@codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.82%. Comparing base (5ae25f7) to head (ea10f5c).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5756   +/-   ##
=======================================
  Coverage   52.81%   52.82%           
=======================================
  Files         279      279           
  Lines       29629    29629           
=======================================
+ Hits        15650    15652    +2     
+ Misses      13162    13160    -2     
  Partials      817      817

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 15, 2025

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra

willie-yao
willie-yao approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 208d79fc96382602a84c119a664d85bfe7d31d0d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 15, 2025

/hold for the test to finish

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2025
@k8s-ci-robot
Copy link
Contributor

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-workload-upgrade ea10f5c link false /test pull-cluster-api-provider-azure-e2e-workload-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 15, 2025

DRA tests are running and green.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit c8c2de8 into kubernetes-sigs:main Jul 15, 2025
25 of 26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jul 15, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Jul 15, 2025
@nojnhuh nojnhuh deleted the dra-e2e branch July 15, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willie-yao willie-yao willie-yao approved these changes

@marosset marosset Awaiting requested review from marosset

Assignees

@willie-yao willie-yao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.21

Development

Successfully merging this pull request may close these issues.

3 participants

@nojnhuh @k8s-ci-robot @willie-yao